[tor-bugs] #24898 [Core Tor/Tor]: We have two conflicting notions of channel_is_client()

[Tor Bug Tracker & Wiki]

#24898: We have two conflicting notions of channel_is_client()
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, 032-backport,             |  Actual Points:
  031-backport, 030-backport-maybe-with-21406,   |
  029-backport-maybe-with-21406, review-         |
  group-30                                       |
Parent ID:                                       |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 It does appear to me that if we use the handshake patch from #24106 that
 we're going to be much better about identifying well-behaved clients
 correctly, and this should be better for the netflow code too (and not
 break it). I am a little worried about misbehaving clients - for those it
 feels smarter to check the digest in cases where that matters for DoS. But
 that should be a separate bug.

 Thanks for this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24898#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online