[tor-bugs] #24911 [Core Tor/Tor]: Remove the known digest check from channel_check_for_duplicates()

[Tor Bug Tracker & Wiki]

#24911: Remove the known digest check from channel_check_for_duplicates()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  refactor, redundant, technical-debt  |  Actual Points:
Parent ID:  #23423                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Replying to [ticket:24911 teor]:
 > the check is already implemented in channel_add_to_digest_map()

 Really? Where in channel_add_to_digest_map does it check if
 channel_is_client() and abort?

 I see a check for chan->identity_digest, but it's not obvious to me that
 that's the same thing, especially wrt, say, handshake-proto=2 connections.
 It would sure be simpler if we could decide to make them the same thing
 though.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24911#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online