[tor-bugs] #24911 [Core Tor/Tor]: Remove the known digest check from channel_check_for_duplicates()

[Tor Bug Tracker & Wiki]

#24911: Remove the known digest check from channel_check_for_duplicates()
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.3.x-final
    Component:  Core     |    Version:
  Tor/Tor                |
     Severity:  Normal   |   Keywords:  refactor, redundant, technical-debt
Actual Points:           |  Parent ID:  #23423
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 This is in arma's commit f5ff9f23 in his bug24898-more branch.

 This comment is wrong, the check is already implemented in
 channel_add_to_digest_map():
 {{{
 +    /* XXX we might want to replace this logic with a call to
 +     * channel_is_client() instead. Or maybe we can change
 +     * channel_identity_mapso it refuses to add any channels that are
 +     * client channels? */
 }}}

 So we can remove the check entirely.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24911>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online