[tor-bugs] #24898 [Core Tor/Tor]: We have two conflicting notions of channel_is_client()

[Tor Bug Tracker & Wiki]

#24898: We have two conflicting notions of channel_is_client()
-------------------------------------------------+-------------------------
 Reporter:  arma                                 |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.1.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-relay, 032-backport,             |  Actual Points:
  031-backport, 030-backport-maybe-with-21406,   |
  029-backport-maybe-with-21406                  |
Parent ID:                                       |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:9 arma]:
 > Commit f5ff9f23 in my {{{bug24898-more}}} branch has a bunch of fixes to
 replace connection_or_digest_is_known_relay() with channel_is_client().
 >
 > Feel free to merge the commit straight-up, or feel free to strip it down
 for parts and take pieces of it for your own commits for all these related
 tickets.

 Let's deal with that in #23423, because all the details are there. It's
 not something we're going to backport.

 If we want to backport arma's bug24898-031 to 0.2.9 and 0.3.0, we need to
 backport:
 * the channel_mark_client() in connection_or_set_state_open() from commit
 af8cadf3a9 in branch bug24898-031 in this ticket
 * the channel_mark_client() in channel_tls_process_netinfo_cell() from
 commit 46fe353f25 in master in #21406

 I am still happy with merging arma's bug24898-031 to 0.3.1 and arma's
 bug24898-2 to master.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24898#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online