[tor-bugs] #24907 [Core Tor/Tor]: Stop ignoring should_refuse_unknown_exits() for unauthenticated channels

[Tor Bug Tracker & Wiki]

#24907: Stop ignoring should_refuse_unknown_exits() for unauthenticated channels
------------------------------+-------------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:  Tor: 0.3.1.1-alpha
     Severity:  Normal        |   Keywords:  easy, intro, regression
Actual Points:                |  Parent ID:
       Points:  0.5           |   Reviewer:
      Sponsor:                |
------------------------------+-------------------------------------
 The brackets in this code are wrong in at least two ways:
 * they unconditionally reject client channels
 * there are two at the start

 {{{
       if ((client_chan ||
            (!connection_or_digest_is_known_relay(
                 or_circ->p_chan->identity_digest) &&
           should_refuse_unknown_exits(options)))) {
 }}}

 Bugfix on d52a1e2 in #22060, note that 66aff2d was merged into that code
 in 0.3.2.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24907>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online