[tor-bugs] #24904 [Core Tor/Tor]: Make geoip use channel_is_client so it ignores flapping relays

[Tor Bug Tracker & Wiki]

#24904: Make geoip use channel_is_client so it ignores flapping relays
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  Medium   |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core     |    Version:
  Tor/Tor                |   Keywords:  easy, intro, refactor, technical-
     Severity:  Normal   |  debt, tor-stats
Actual Points:           |  Parent ID:  #23423
       Points:  0.5      |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 In channel_do_open_actions(), we probably want to use channel_is_client()
 rather than connection_or_digest_is_known_relay().

 {{{
     /* only report it to the geoip module if it's not a known router */
     if (!connection_or_digest_is_known_relay(chan->identity_digest)) {
       if (channel_get_addr_if_possible(chan, &remote_addr)) {
 }}}

 Bugfix on #23533, 0.3.0.1-alpha.

 We should make sure #24898 is fixed in any version we backport this to.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24904>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online