[tor-bugs] #24895 [Core Tor/Tor]: MAX_REND_FAILURES is 1, but we will try three times

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jan 15 21:34:34 UTC 2018


#24895: MAX_REND_FAILURES is 1, but we will try three times
--------------------------+------------------------------------
 Reporter:  arma          |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  032-backport  |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by arma):

 * status:  new => needs_review


Comment:

 I made a {{{bug24895}}} branch in my arma. It's based on maint-0.2.9,
 since I think fixing it that far back is wise given that 0.2.9 will remain
 LTS for so long.

 There will probably be some simple conflicts as we forward-port, but it's
 a one-liner plus a comment so hopefully it won't be too bad.

 Really I want to change the logic around so we increment the failure count
 earlier in the function, but I think we should wait until 0.3.3 for that
 refactoring.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24895#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list