[tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-proposed, tor-control, easy,     |  Actual Points:
  spec-conformance                               |
Parent ID:                                       |         Points:  .1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 routerstatus_has_changed() checks for some differences in descriptors.
 This is the right thing to do when the function is called from some code.
 But it hides some changed descriptors from controllers.

 When called from control port code, the function should check if the
 timestamp has changed. That will give the controller *all* the changed
 descriptors.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20218#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online