[tor-bugs] #24423 [Core Tor/Tor]: Fix STACK warnings in Tor

[Tor Bug Tracker & Wiki]

#24423: Fix STACK warnings in Tor
----------------------------------------------+----------------------------
 Reporter:  nickm                             |          Owner:  nickm
     Type:  defect                            |         Status:
                                              |  needs_review
 Priority:  Medium                            |      Milestone:  Tor:
                                              |  0.3.3.x-final
Component:  Core Tor/Tor                      |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  review-group-27, review-group-29  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:  catalyst                          |        Sponsor:
----------------------------------------------+----------------------------

Comment (by gk):

 Replying to [comment:33 catalyst]:
 > Do we get this STACK warning if we build with `ALL_BUGS_ARE_FATAL`?  If
 not, I'm inclined to leave it as is and recommend that people run STACK
 with that defined.

 No, that warning does not show up anymore. However, a new one pops up
 (with commit 29784d80faab3d8307916c7a945e89fe082e3db0) in that case:
 {{{
 ---
 bug: anti-simplify
 model: |
   %tobool19 = icmp ne %struct.workerthread_s* %27, null, !dbg !315
   -->  true
 stack:
   -
 /home/thomas/Arbeit/hardening/stack/build36/tor_fatal2/../../../../Tor/tor/src/common/workqueue.c:508:9
 ncore: 1
 core:
   -
 /home/thomas/Arbeit/hardening/stack/build36/tor_fatal2/../../../../Tor/tor/src/common/workqueue.c:337:3
     - null pointer dereference
 ---
 bug: anti-simplify
 model: |
   %tobool19 = icmp ne %struct.workerthread_s* %27, null, !dbg !315
   -->  true
 stack:
   -
 /home/thomas/Arbeit/hardening/stack/build36/tor_fatal2/../../../../Tor/tor/src/common/workqueue.c:508:9
 ncore: 1
 core:
   -
 /home/thomas/Arbeit/hardening/stack/build36/tor_fatal2/../../../../Tor/tor/src/common/workqueue.c:337:3
     - null pointer dereference
 }}}
 The patch in `stack_em_up` on the other hand solves this problem without
 creating new warnings. I think that's preferable to keeping a list of
 false positives (because `ALL_BUGS_ARE_FATAL` wouldn't be defined in any
 release build anyway).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24423#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online