[tor-bugs] #20218 [Core Tor/Tor]: Fix and refactor and redocument routerstatus_has_changed

[Tor Bug Tracker & Wiki]

#20218: Fix and refactor and redocument routerstatus_has_changed
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  029-proposed, tor-control, easy,     |  Actual Points:
  spec-conformance                               |
Parent ID:                                       |         Points:  .1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 There are a few different issues:
 * the function comment needs to say that the function checks for semantic
 changes
 * the function is used by two different parts of the code, and the
 controller part needs it to check for more changes

 The controller part of the code wants all new descriptors:
 https://gitweb.torproject.org/torspec.git/tree/control-spec.txt#n2144

 The other part of the code just wants descriptors that are different
 enough to matter.

 This means adding an argument to the function that makes it check for
 different kinds of changes. Or making two functions. But we try not to
 copy and paste code, we get functions to call other functions instead.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20218#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online