[tor-bugs] #24642 [Obfuscation/meek]: cannot use TOR_PT_EXIT_ON_STDIN_CLOSE with meek-client-torbrowser

[Tor Bug Tracker & Wiki]

#24642: cannot use TOR_PT_EXIT_ON_STDIN_CLOSE with meek-client-torbrowser
------------------------------+---------------------
 Reporter:  mcs               |          Owner:  dcf
     Type:  defect            |         Status:  new
 Priority:  Medium            |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:                    |  Actual Points:
Parent ID:  #24689            |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+---------------------

Comment (by yawning):

 Replying to [comment:5 dcf]:
 > Replying to [comment:4 yawning]:
 > > Replying to [comment:2 dcf]:
 > > > I was pretty surprised by this, because I was under the impression
 that tor always sets `TOR_PT_EXIT_ON_STDIN_CLOSE=1` nowadays, and
 therefore this code should never have worked in any released bundle. But
 it turns out it only sets the variable for server transports, not client
 transports, which is why this bug wasn't detected earlier:
 > >
 > > I don't remember why it only does that on servers.  Should it set the
 env var for clients as well?
 >
 > I had assumed that it was set for clients too. I can't think of a reason
 why it wouldn't be (except for this bug, of course).

 I certainly intended for it to be everywhere when I added the construct,
 and obfs4proxy checks the env var regardless of if it is a client or
 server.  I looked back at my commit, and the code's unchanged from when I
 added the patch, so I guess it's a bug that's always been there.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24642#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online