[tor-bugs] #24642 [Obfuscation/meek]: cannot use TOR_PT_EXIT_ON_STDIN_CLOSE with meek-client-torbrowser

[Tor Bug Tracker & Wiki]

#24642: cannot use TOR_PT_EXIT_ON_STDIN_CLOSE with meek-client-torbrowser
------------------------------+---------------------
 Reporter:  mcs               |          Owner:  dcf
     Type:  defect            |         Status:  new
 Priority:  Medium            |      Milestone:
Component:  Obfuscation/meek  |        Version:
 Severity:  Normal            |     Resolution:
 Keywords:                    |  Actual Points:
Parent ID:  #24689            |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+---------------------

Comment (by mcs):

 Replying to [comment:2 dcf]:
 > You're right. This is a bug in meek-client-torbrowser.
 >
 > Better than unsetting `TOR_PT_EXIT_ON_STDIN_CLOSE`, I think, is to
 actually give the meek-client subprocess a stdin, something like this:
 > ...
 > Another (possibly better) option is to call `cmd.StdinPipe()` and just
 never close the pipe (that way the child process's stdin is separate from
 the parent's, so you don't have a race between them trying to terminate
 when the stdin is closed).

 The above makes sense to me. `cmd.StdinPipe()` seems like a good solution.
 Kathy and I can test such a patch if you'd like us to do so.

 > ...
 > What do you need from me, a new tag with this bug fixed?

 Yes.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24642#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online