[tor-bugs] #24826 [Core Tor/Tor]: LZMA- and Zstandard compressed consensus diffs stall Tor Browser launch for at least 20s or break it entirely

[Tor Bug Tracker & Wiki]

#24826: LZMA- and Zstandard compressed consensus diffs stall Tor Browser launch for
at least 20s or break it entirely
--------------------------+------------------------------------
 Reporter:  gk            |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:  #22341        |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------

Comment (by nickm):

 Hm. On 0.3.2, I failed to see this bug happen.  The timing was:
 {{{
 Jan 10 09:25:35.000 [debug] dir_client_decompress_response_body():
 Successfully
 decompressed body using LZMA compressed
 Jan 10 09:25:35.000 [debug] consensus_diff_apply(): About to apply
 consensus dif
 f.
 Jan 10 09:25:35.000 [debug] consensus_diff_apply(): Computed digest-as-
 signed fo
 r applying consensus diff.
 Jan 10 09:25:35.000 [debug] consdiff_apply_diff(): Extracted digests for
 consens
 us diff.
 Jan 10 09:25:35.000 [debug] consdiff_apply_diff(): Digests match; applying
 diff.
 Jan 10 09:25:35.000 [debug] consdiff_apply_diff(): Diff applied.
 Jan 10 09:25:35.000 [debug] consdiff_apply_diff(): Computing digest of
 resulting
  consensus.
 Jan 10 09:25:35.000 [debug] consdiff_apply_diff(): Digests are equal; diff
 appli
 cation succeeded.
 Jan 10 09:25:35.000 [info] handle_response_fetch_consensus(): Applied
 consensus
 diff (size 97517) from server '154.35.175.225:443', resulting in a new
 consensus
  document (size 1885985).
 }}}

 I'll try again with the same patch on 0.3.3.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24826#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online