[tor-bugs] #22983 [Metrics/Library]: Add a Descriptor subinterface and implementation for Tor web server logs

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jan 10 13:39:25 UTC 2018

#22983: Add a Descriptor subinterface and implementation for Tor web server logs
 Reporter:  iwakeh           |          Owner:  metrics-team
     Type:  enhancement      |         Status:  needs_review
 Priority:  High             |      Milestone:  metrics-lib 2.2.0
Component:  Metrics/Library  |        Version:
 Severity:  Normal           |     Resolution:
 Keywords:  metrics-2018     |  Actual Points:
Parent ID:                   |         Points:
 Reviewer:                   |        Sponsor:

Comment (by iwakeh):

 Replying to [comment:56 karsten]:
 > I started looking at your branch, but it's a pretty big diff again, so
 that'll take some time.

 You only need to look at the latest four commits.  The others are reviewed
 already (comment:47).

 > Regarding Git history, we're going to squash all these commits (except
 for unrelated ones like adding a space or package-info) into a single
 commit that adds interfaces, implementations, and tests, right? I'm
 asking, because you marked some commits as "fixup!", but not all of them.
 Or do you have a separation in mind? If so, which?

 Maybe, keep those that you find easier to understand the changes.  I used
 'fixup' for making clear that a change is related to an earlier review

 > By the way, what was the reason for rebasing your branch? It would have
 been a tad bit easier to stay on the same branch until we're done with the
 review process. Just saying for future reviews.

 You mentioned that above already ;-)

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22983#comment:57>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tor-bugs mailing list