[tor-bugs] #16255 [Core Tor/Tor]: Guardfraction on dirauths screws up bandwidth weights

[Tor Bug Tracker & Wiki]

#16255: Guardfraction on dirauths screws up bandwidth weights
-------------------------------------------------+-------------------------
 Reporter:  asn                                  |          Owner:  asn
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  unspecified
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dirauth, tor-guard, mike-can,    |  Actual Points:
  SponsorU-deferred                              |         Points:
Parent ID:                                       |  medium/large
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by asn):

 * status:  needs_revision => needs_review


Comment:

 OK I did it! I ripped off the code from the codebase. Here are the
 rewards:
 {{{
 19 files changed, 11 insertions(+), 1063 deletions(-)
 }}}

 Please see branch `ticket24456` in my repo for this. Tests pass and `make
 test-network-all` pass. The diff is pretty simple.

 Rationale for the removal is cited in the commit msg.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16255#comment:37>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online