[tor-bugs] #24555 [Core Tor/Tor]: Bug: tor_gmtime_r overflow - gmtime(9223372036854775807) failed with error No error

[Tor Bug Tracker & Wiki]

#24555: Bug: tor_gmtime_r overflow - gmtime(9223372036854775807) failed with error
No error
-------------------------------------------------+-------------------------
 Reporter:  s7r                                  |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  unspecified
 Severity:  Normal                               |     Resolution:
 Keywords:  integer-overflow time-overflow tor-  |  Actual Points:
  relay 2038-problem                             |
Parent ID:  #18480                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 Ok. Getting back into the swing of this developer thing.

 This bug was introduced in commit a1b0a0b9, which hasn't come out in any
 release yet (i.e. I don't think it's an issue in 0.3.2).

 This issue is that ri->cert_expiration_time is TIME_MAX if there isn't an
 ed cert in the descriptor, so doing a format_iso_time() call on it before
 we know that router_add_to_routerlist() returned ROUTER_CERTS_EXPIRED
 means that we might be handing format_iso_time a TIME_MAX, which is bigger
 than INT32_MAX so it will warn.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24555#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online