[tor-bugs] #23101 [Core Tor/Tor]: Predict and build specific HS purpose circuits (rather than GENERAL)

[Tor Bug Tracker & Wiki]

#23101: Predict and build specific HS purpose circuits (rather than GENERAL)
-------------------------------------------------+-------------------------
 Reporter:  mikeperry                            |          Owner:
                                                 |  mikeperry
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, tor-guard, guard-discovery-  |  Actual Points:
  prop247-controller, review-group-27            |
Parent ID:  #13837                               |         Points:
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by asn):

 Replying to [comment:18 mikeperry]:
 > You're right, I could have separated the pre-building of HS_GENERAL from
 the cannibalization of them (similar to how I did in #13837). I forgot to
 do that in the rush to get this done. I'll keep it in mind for next time.
 >
 > As for the next steps, I took your dev patches and squashed them into
 mikeperry/bug23101-rebased, and the result is mikeperry/bug23101-squashed,
 which is rebased onto the freshly squashed+cleaned
 mikeperry/bug13837-squashed.
 https://oniongit.eu/mikeperry/tor/commits/bug23101-squashed if you want to
 comment there some more.
 >
 > I'm now out until ~Jan 2. Leaving this in needs_revision because I am
 wary of the issue you found in #13837.

 Yo yo, I'm back and took some time to look into this again.

 I suggested a potential fix for the #13837 issue in gitlab.
 I also noticed that there is no #23101 in your `bug23101-squashed` branch,
 so I couldn't really test that one. I'll wait till the commit pops up to
 continue testing!

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23101#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online