[tor-bugs] #19675 [Applications/Tor Browser]: Merge Orfox patches into tor-browser

[Tor Bug Tracker & Wiki]

#19675: Merge Orfox patches into tor-browser
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  igt0
     Type:  task                                 |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, ff52-esr,                |  Actual Points:
  TorBrowserTeam201712                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by igt0):

 I am not sure if it is related to this merge however we need to sync the:
 https://github.com/sysrqb/tor-browser/blob/tor-
 browser-52.5.2esr-7.5-2_attempt0_1/mobile/android/app/mobile.js

 with the

 https://gitweb.torproject.org/tor-
 browser.git/tree/modules/libpref/init/all.js?h=tor-browser-52.5.2esr-7.5-2

 Replying to [comment:9 sysrqb]:
 > I rebased the Orfox commits on tor-browser-52.5.2esr-7.5-2. This
 includes all commits from orfox-tor-browser-52.2.0esr-7.0-1, but with some
 modifications.
 >
 > 1) Rename .mozconfig-orfox as .mozconfig-android
 > 2) Align .mozconfig-android configuration with .mozconfig configuration
 > 3) Add comments on non-obvious configuration changes
 > 4) Bump Java JDK version from openjdk-7 to openjdk-8 (openjdk-7 is EOL)
 > 5) Bump Android NDK version from r11b to r11c (hash of r11c is published
 on the Android website, r11b's hash is not available)
 > 6) Verify sha256sum hash of downloaded SDK and NDK files match
 expected/published value
 >
 > There are a few outstanding changes that are needed:
 > 1) Compiling with tests enabled fails
 > 2) App crashes when running in an Android emulator (it does not crash
 when running on a device)
 > 3) Change the app name from Orfox to Tor Browser(?)
 > 4) We need more unit tests
 > 5) c823adc2da01ee47d50e03f1a5a4f14e661e8a2c adds a third-party
 extension, we need integrate its changes instead
 > 6) Audit mobile.js and confirm it matches browser.js
 > 7) Some of the commits add whitespace, we should clean before merging
 >
 >
 > branch is tor-browser-52.5.2esr-7.5-2_attempt0_1 at
 https://github.com/sysrqb/tor-browser/tree/tor-
 browser-52.5.2esr-7.5-2_attempt0_1
 >
 > I have some more notes from my review, I will add them here after I
 think about them some more.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/19675#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online