[tor-bugs] #25375 [Core Tor/Tor]: Remove as many items as possible from second_elapsed_callback() and run_scheduled_events()

[Tor Bug Tracker & Wiki]

#25375: Remove as many items as possible from second_elapsed_callback() and
run_scheduled_events()
------------------------------+--------------------------------
     Reporter:  nickm         |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:
Actual Points:                |  Parent ID:
       Points:                |   Reviewer:
      Sponsor:  Sponsor8      |
------------------------------+--------------------------------
 We have a real system for periodic events and deferred events and so on --
 several of them, in fact.  We shouldn't be using second_elapsed_callback()
 and run_scheduled_events() to do things any more:
   * Some things should be done as soon as possible, on demand (see
 #25374).
   * Some things should be done on the timers from periodic.c.
   * Some things should be done with one-off timers schedueld "for later".

 And some things might still need to be done once a second -- but they
 should be things that only need to happen when Tor is running.  When Tor
 is idle or hibernating, or when DisableNetwork is set, we should be able
 to disable those once-per-second events so that we don't use so much CPU.

 '''Please make subtickets for removing things from these functions.'''

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25375>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online