[tor-bugs] #25365 [Core Tor/Tor]: Use uint64_t for Tor's hash tables, even if int is 32 bits

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue Feb 27 01:31:29 UTC 2018


#25365: Use uint64_t for Tor's hash tables, even if int is 32 bits
------------------------------+--------------------------------
     Reporter:  teor          |      Owner:  (none)
         Type:  defect        |     Status:  new
     Priority:  Medium        |  Milestone:  Tor: 0.3.4.x-final
    Component:  Core Tor/Tor  |    Version:
     Severity:  Normal        |   Keywords:  security-low
Actual Points:                |  Parent ID:
       Points:  1             |   Reviewer:
      Sponsor:                |
------------------------------+--------------------------------
 64-bit macOS and BSD are LP64, which means that their ints are 32 bits.
 This makes Tor's hash tables 32 bits, reducing their security.

 This issue also occurs on 32-bit systems, where using uint64_t might be
 slower. I don't know if speed matters, as siphash is 64 bit anyway.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25365>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list