[tor-bugs] #25341 [Core Tor/Tor]: Remove now-unnecessary Rust linking workaround

[Tor Bug Tracker & Wiki]

#25341: Remove now-unnecessary Rust linking workaround
---------------------------------------+-----------------------------------
 Reporter:  isis                       |          Owner:  (none)
     Type:  enhancement                |         Status:  needs_review
 Priority:  Medium                     |      Milestone:  Tor:
                                       |  0.3.4.x-final
Component:  Core Tor/Tor               |        Version:  Tor:
                                       |  0.3.2.2-alpha
 Severity:  Normal                     |     Resolution:
 Keywords:  rust, tor-build, autoconf  |  Actual Points:
Parent ID:                             |         Points:  .1
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------------------
Description changed by isis:

Old description:

> We've got the following stanza in our `configure.ac`:
>
> {{{
>   dnl This is a workaround for #46797
>   dnl (a.k.a https://github.com/rust-lang/rust/issues/46797 ).  Once the
>   dnl upstream bug is fixed, we can remove this workaround.
>   case "$host_os" in
>       darwin*)
>         TOR_RUST_EXTRA_LIBS="-lresolv"
>     ;;
>   esac
> }}}
>
> It looks like https://github.com/rust-lang/rust/issues/46797 has been
> resolved as of 18 December 2017, so we can probably remove this
> workaround now! (Someone who is on MacOS should probably test this, I
> don't have access to any Macs right now.)

New description:

 We've got the following stanza in our `configure.ac`:

 {{{
   dnl This is a workaround for #46797
   dnl (a.k.a https://github.com/rust-lang/rust/issues/46797 ).  Once the
   dnl upstream bug is fixed, we can remove this workaround.
   case "$host_os" in
       darwin*)
         TOR_RUST_EXTRA_LIBS="-lresolv"
     ;;
   esac
 }}}

 It looks like https://github.com/rust-lang/rust/issues/46797 has been
 resolved as of 22 January 2018, so we can probably remove this workaround
 now! (Someone who is on MacOS should probably test this, I don't have
 access to any Macs right now.)

--

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25341#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online