[tor-bugs] #25260 [Applications/Tor Launcher]: Merge mozbuild files into tor-launcher.git

[Tor Bug Tracker & Wiki]

#25260: Merge mozbuild files into tor-launcher.git
---------------------------------------+-----------------------
 Reporter:  sysrqb                     |          Owner:  brade
     Type:  enhancement                |         Status:  new
 Priority:  Medium                     |      Milestone:
Component:  Applications/Tor Launcher  |        Version:
 Severity:  Normal                     |     Resolution:
 Keywords:                             |  Actual Points:
Parent ID:  #24856                     |         Points:
 Reviewer:                             |        Sponsor:
---------------------------------------+-----------------------

Comment (by sysrqb):

 After a few more days with this, and chatting with some Mozilla devs, I
 made some more progress on this. In the short term, we can bundle tor-
 launcher as a system add-on and it should (mostly) just-work. This will
 require a small patch in tor-browser.git for adding the new directory into
 the moz build system, and tor-browser-builder won't build tor-launcher
 independently anymore. This ticket is still relevant for merging build
 config into tor-launcher.git.

 I found Mozilla introduced some breaking changes over the last few
 releases [0][1], so I patched those in TL, as well. Currently system add-
 ons do not work on android, so I opened a ticket (with a patch) for
 that[2].

 The current tor-launcher patch branch is enhancement25260 [3]

 It creates a features extension. The trickiest part of this desktop and
 android expect the features/ directory in different locations. On desktop,
 is it browser/features/ but on mobile it's only features/. I created a
 build-time variable that defines in which directory the extension should
 be stored, then I set DIST_SUBDIR as the correct location.

 [0] https://bugzilla.mozilla.org/show_bug.cgi?id=1149830
 [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1374847
 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1440789
 [3] https://github.com/sysrqb/tor-launcher/tree/enhancement25260

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25260#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online