[tor-bugs] #25150 [Core Tor/Tor]: Avoid malloc/free on each server-side ntor handshake

[Tor Bug Tracker & Wiki]

#25150: Avoid malloc/free on each server-side ntor handshake
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  c99, malloc, performance, ntor,      |  Actual Points:
  review-group-32                                |
Parent ID:  #23777                               |         Points:
 Reviewer:  isis                                 |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 I've reproduced the fragile-hardening thing; it appears to be GCC-only
 though.

 I've merged, and made a change to fix it, as
 4d994e7a9c8936c9e33df90b7468e7327f1794e9

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25150#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online