[tor-bugs] #16472 [Applications/Tor Browser]: Upgrade Binutils to 2.25+ for Tor Browser builds

[Tor Bug Tracker & Wiki]

#16472: Upgrade Binutils to 2.25+ for Tor Browser builds
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  task                      |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm, boklm201802      |  Actual Points:
Parent ID:  #12968                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by boklm):

 Adding `static` to kLogStrings is indeed fixing the issue.

 The next error is:
 {{{
 + exec /var/tmp/dist/gcc/bin/gcc
 -B/var/tmp/dist/selfrando/Tools/TorBrowser/tc-wrapper -ffunction-sections
 -fdata-sections -fPIC -m32 -std=gnu99 -shared -Wl,--gc-section
 s -Wl,-z,defs -Wl,-soname -Wl,libnssutil3.so -Wl,--version-
 script,/var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/nssutil.def -o /var/tmp
 /build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/libnssutil3.so /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/qu
 ickder.o /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/secdig.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/
 lib/util/derdec.o /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/derenc.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/secu
 rity/nss/lib/util/dersubr.o /var/tmp/build/firefox-017a7ad9488d/obj-i686
 -pc-linux-gnu/security/nss/lib/util/dertime.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-lin
 ux-gnu/security/nss/lib/util/errstrs.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/nssb64d.o
 /var/tmp/build/firefox-017a7ad9488d/obj-
 i686-pc-linux-gnu/security/nss/lib/util/nssb64e.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/nssrwlk.o
 /var/tmp/build/firefox-017a7a
 d9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/nssilock.o
 /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/oidstring.o /var/tmp/build/
 firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/pkcs1sig.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/portreg.o /va
 r/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/secalgid.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/s
 ecasn1d.o /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/secasn1e.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/n
 ss/lib/util/secasn1u.o /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-
 linux-gnu/security/nss/lib/util/secitem.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gn
 u/security/nss/lib/util/secload.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/secoid.o
 /var/tmp/build/firefox-017a7ad9488d/obj-i686-p
 c-linux-gnu/security/nss/lib/util/sectime.o /var/tmp/build/firefox-
 017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/secport.o
 /var/tmp/build/firefox-017a7ad9488d
 /obj-i686-pc-linux-gnu/security/nss/lib/util/templates.o /var/tmp/build
 /firefox-017a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/utf8.o
 /var/tmp/build/firefox-01
 7a7ad9488d/obj-i686-pc-linux-gnu/security/nss/lib/util/utilmod.o
 /var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/utilpars.o -L/var/tmp/bu
 ild/firefox-017a7ad9488d/obj-i686-pc-linux-gnu/dist/lib -L/var/tmp/build
 /firefox-017a7ad9488d/obj-i686-pc-linux-gnu/dist/bin -lplc4 -lplds4
 -lnspr4 -lpthread -ldl -lc
 collect2: fatal error: ld terminated with signal 6 [Aborted]
 compilation terminated.
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.12' and 'NSSUTIL_3.12.3' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.12.3' and 'NSSUTIL_3.12.5' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.12.5' and 'NSSUTIL_3.12.7' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.12.7' and 'NSSUTIL_3.13' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.13' and 'NSSUTIL_3.14' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.14' and 'NSSUTIL_3.15' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.15' and 'NSSUTIL_3.17.1' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.17.1' and 'NSSUTIL_3.21' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: warning: wildcard match appears
 in both version 'NSSUTIL_3.21' and 'NSSUTIL_3.24' in script
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-Dtc3WlhCcG:
 relocation R_386_GOTOFF against preemptible symbol
 SEC_SequenceOfObjectIDTemplate cannot be used
  when making a shared object
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-Dtc3WlhCcG:
 relocation R_386_GOTOFF against preemptible symbol
 SEC_PointerToGeneralizedTimeTemplate cannot b
 e used when making a shared object
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-Dtc3WlhCcG:
 relocation R_386_GOTOFF against preemptible symbol
 SEC_PointerToEnumeratedTemplate cannot be use
 d when making a shared object
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-Dtc3WlhCcG:
 relocation R_386_GOTOFF against preemptible symbol
 SEC_SequenceOfAnyTemplate cannot be used when making a shared object
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-cDg6BKy5jw:
 relocation R_386_GOTOFF against preemptible symbol
 sgn_DigestInfoTemplate_Util cannot be used when making a shared object
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-cDg6BKy5jw:
 relocation R_386_GOTOFF against preemptible symbol
 SEC_SetOfAnyTemplate_Util cannot be used when making a shared object
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-cDg6BKy5jw:
 relocation R_386_GOTOFF against preemptible symbol
 SEC_PointerToOctetStringTemplate_Util cannot be used when making a shared
 object
 /var/tmp/dist/binutils/bin/ld.gold.real: error: /tmp/trapobj-cDg6BKy5jw:
 relocation R_386_GOTOFF against preemptible symbol
 SEC_PointerToAnyTemplate_Util cannot be used when making a shared object
 Linker execution failed, status: 1
 ld: src/Support/posix/Debug.cpp:36: void Error::printf(const char*, ...):
 Assertion `false' failed.
 make[7]: *** [/var/tmp/build/firefox-017a7ad9488d/obj-i686-pc-linux-
 gnu/security/nss/lib/util/libnssutil3.so] Error 1
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/16472#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online