[tor-bugs] #25150 [Core Tor/Tor]: Avoid malloc/free on each server-side ntor handshake

[Tor Bug Tracker & Wiki]

#25150: Avoid malloc/free on each server-side ntor handshake
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  enhancement                          |         Status:
                                                 |  merge_ready
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.4.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  c99, malloc, performance, ntor,      |  Actual Points:
  review-group-32                                |
Parent ID:  #23777                               |         Points:
 Reviewer:  isis                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by isis):

 * status:  needs_review => merge_ready


Comment:

 This change looks fine to me.  I looked into why it might be breaking with
 --enable-fragile-hardening (which our Travis builds also use) and it
 [https://travis-ci.org/isislovecruft/tor/jobs/341633581 appears to be an
 issue] with clang's LeakSanitizer detecting the leaks from #25127 ([https
 ://travis-ci.org/isislovecruft/tor/builds/341633577 the other GCC builds
 and non-Rust builds completed just fine]). After rebasing it on top of the
 #25127 fix, [https://travis-ci.org/isislovecruft/tor/builds/341658322
 clang seems happy].

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25150#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online