[tor-bugs] #24902 [Core Tor/Tor]: Denial of Service mitigation subsystem

[Tor Bug Tracker & Wiki]

#24902: Denial of Service mitigation subsystem
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  dgoulet
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ddos, tor-relay, review-group-30,    |  Actual Points:
  029-backport, 031-backport, 032-backport,      |
  review-group-31, SponsorV                      |
Parent ID:                                       |         Points:
 Reviewer:  arma                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  merge_ready => needs_revision


Comment:

 The man page doesn't document the defaults when there is no consensus
 parameter set:
 {{{
 /* DoSCircuitCreationEnabled default. Disabled by default. */
 #define DOS_CC_ENABLED_DEFAULT 0
 /* DoSCircuitCreationDefenseType maps to the dos_cc_defense_type_t enum.
 */
 #define DOS_CC_DEFENSE_TYPE_DEFAULT DOS_CC_DEFENSE_REFUSE_CELL
 /* DoSCircuitCreationMinConnections default */
 #define DOS_CC_MIN_CONCURRENT_CONN_DEFAULT 3
 /* DoSCircuitCreationRateTenths is 3 per seconds. */
 #define DOS_CC_CIRCUIT_RATE_DEFAULT 3
 /* DoSCircuitCreationBurst default. */
 #define DOS_CC_CIRCUIT_BURST_DEFAULT 90
 /* DoSCircuitCreationDefenseTimePeriod in seconds. */
 #define DOS_CC_DEFENSE_TIME_PERIOD_DEFAULT (60 * 60)
 ...
 /* DoSConnectionEnabled default. Disabled by default. */
 #define DOS_CONN_ENABLED_DEFAULT 0
 /* DoSConnectionMaxConcurrentCount default. */
 #define DOS_CONN_MAX_CONCURRENT_COUNT_DEFAULT 100
 /* DoSConnectionDefenseType maps to the dos_conn_defense_type_t enum. */
 #define DOS_CONN_DEFENSE_TYPE_DEFAULT DOS_CONN_DEFENSE_CLOSE
 }}}

 And there is no #define for the default DoSRefuseSingleHopClientRendezvous
 setting in dos.h. Its default should be documented in the man page, even
 if we don't add a #define.

 Also, the reference to DoSCircuitCreationRateTenths in the above code is
 outdated.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24902#comment:68>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online