[tor-bugs] #25202 [Core Tor/Tor]: Check the calculations in cc_stats_refill_bucket using non fatal assertions

[Tor Bug Tracker & Wiki]

#25202: Check the calculations in cc_stats_refill_bucket using non fatal assertions
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Low           |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-dos       |  Actual Points:
Parent ID:  #24902        |         Points:  0.1
 Reviewer:                |        Sponsor:
--------------------------+------------------------------------
Changes (by dgoulet):

 * priority:  Medium => Low


Comment:

 I'm ok with both asserts, no strong opinion on this. I don't think the
 first assert is really useful for "safety" as it is more about safety for
 "future code change" which I hope also the unit tests will catch anything
 on that front.

 The second assert is interesting as it reinforces the fact that the
 function can ONLY increment the bucket or set it to the allowed burst that
 could be smaller than the current count.

 Both cases, I see this as a defense in depth.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25202#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online