[tor-bugs] #25127 [Core Tor/Tor]: Rust implementation of protover_get_supported_protocols() leaks memory

Mon Feb 5 23:21:01 UTC 2018

#25127: Rust implementation of protover_get_supported_protocols() leaks memory
----------------------------------+------------------------------------
 Reporter:  nickm                 |          Owner:  isis
     Type:  defect                |         Status:  assigned
 Priority:  Medium                |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor          |        Version:
 Severity:  Normal                |     Resolution:
 Keywords:  rust, protover, leak  |  Actual Points:
Parent ID:                        |         Points:
 Reviewer:                        |        Sponsor:
----------------------------------+------------------------------------

Comment (by teor):

 This issue also affects protover_compute_for_old_tor().
 All the other strings passed from Rust to C are freed correctly.

 I think we need a new rule to catch bugs like this one:
 "The C unit tests must call every Rust ffi function."

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25127#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online