[tor-bugs] #24975 [Core Tor/Tor]: sched: scheduler_notify_networkstatus_changed() calls select_scheduler() without the new consensus

[Tor Bug Tracker & Wiki]

#24975: sched: scheduler_notify_networkstatus_changed() calls select_scheduler()
without the new consensus
-------------------------------------+------------------------------------
 Reporter:  dgoulet                  |          Owner:  dgoulet
     Type:  defect                   |         Status:  needs_review
 Priority:  High                     |      Milestone:  Tor: 0.3.3.x-final
Component:  Core Tor/Tor             |        Version:
 Severity:  Normal                   |     Resolution:
 Keywords:  032-backport, tor-sched  |  Actual Points:
Parent ID:                           |         Points:
 Reviewer:  armadev                  |        Sponsor:
-------------------------------------+------------------------------------

Comment (by arma):

 New branch looks ok.

 The changelog says "This lead [sic] to the scheduler failing to notice any
 consensus parameters that might have changed between consensuses" but I
 think it isn't quite that bad -- the bug meant that you picked up the new
 consensus params on the following consensus fetch.

 So it could count as a minor bugfix and go only on master if we wanted to
 be more conservative.

 Speaking of conflicts, when this gets merged there will be a conflict with
 the new dos_consensus_has_changed() call, which can be put in either the
 notify_before or notify_after function, so long as it's done right.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24975#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online