[tor-bugs] #28939 [Core Tor]: Fix buffer overflow in src/test/test_voting_flags.c

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Dec 24 00:09:26 UTC 2018


#28939: Fix buffer overflow in src/test/test_voting_flags.c
--------------------+--------------------------
 Reporter:  kjak    |          Owner:  (none)
     Type:  defect  |         Status:  new
 Priority:  Medium  |      Component:  Core Tor
  Version:          |       Severity:  Normal
 Keywords:          |  Actual Points:
Parent ID:          |         Points:
 Reviewer:          |        Sponsor:
--------------------+--------------------------
 In `setup_cfg()` in src/test/test_voting_flags.c a memset is used to write
 `DIGEST256_LEN` (32) bytes into `signed_descriptor_digest` of length
 `DIGEST_LEN` (20).

 I see 12 bytes of the previously-filled `identity_digest` being
 overwritten.

 PR to follow.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28939>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list