[tor-bugs] #28806 [Core Tor/Tor]: checkIncludes.py does not like code in src/ext/timeouts

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Dec 23 17:04:40 UTC 2018


#28806: checkIncludes.py does not like code in src/ext/timeouts
--------------------------+----------------------------------
 Reporter:  rl1987        |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Low           |      Milestone:  Tor: unspecified
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+----------------------------------
Changes (by rl1987):

 * priority:  Medium => Low


Comment:

 These are just warnings, but it seems mentioned lines of
 src/ext/timeouts/.may_include do not match any of the following regular
 expressions:
 {{{
  54 ALLOWED_PATTERNS = [
  55     re.compile(r'^.*\*\.(h|inc)$'),
  56     re.compile(r'^.*/.*\.h$'),
  57     re.compile(r'^ext/.*\.c$'),
  58     re.compile(r'^orconfig.h$'),
  59     re.compile(r'^micro-revision.i$'),
  60 ]
 }}}

 What should we do? Add one or more entries to this list? I would like to
 hear from Nick or someone else who worked on checkIncludes script.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28806#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list