[tor-bugs] #28902 [Core Tor/Nyx]: GETINFO commands with huge outputs slow down interpreter curses interface

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Dec 19 18:32:55 UTC 2018


#28902: GETINFO commands with huge outputs slow down interpreter curses interface
--------------------------+--------------------------
 Reporter:  wagon         |          Owner:  atagar
     Type:  defect        |         Status:  assigned
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Nyx  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  curses        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+--------------------------

Comment (by atagar):

 Ah! So that ticket was about the control interpreter. That makes a lot
 more sense (I thought you were talking about an internal 'GETINFO desc
 /all-recent' invocation).

 If you're running that command three times the control interpreter has
 accumulated roughly 1080078 lines of content. The draw method then
 iterates over that which is probably the source of the problem...

 https://gitweb.torproject.org/nyx.git/tree/nyx/panel/interpreter.py#n133

 This should be easy to fix. Rather than looping over the whole list we
 should splice to the visible range.

 Honestly I won't be getting to this any time soon, but I'd be happy to
 merge the fix if you'd care to whip it up. Otherwise I'll get to it when I
 have time.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28902#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list