[tor-bugs] #28865 [Core Tor/sbws]: sbws keeps the number of AsyncResults less than the number of threads

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Dec 19 18:31:23 UTC 2018


#28865: sbws keeps the number of AsyncResults less than the number of threads
---------------------------+-----------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |        Version:  sbws: 1.0.2
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #28663         |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-----------------------------------

Comment (by juga):

 Replying to [ticket:28865 teor]:
 [...]
 > There are two different ways that this code blocks execution:
 > * when a result finishes, the `time.sleep(5)` call blocks the thread
 from getting a new `AsyncResult` for up to 5 seconds

 the main thread blocks, but not the workers.

 > * if `max_pending_results` `AsyncResult`s ever block, the process hangs

 and that would mean there's a deadlock or a bug somewhere else. Probably
 the cause (or at least the main one) is #28897.
 What i would to detect future bugs, is give a maximum timeout to both
 while loops, then print a backtrace and ask the user to open a ticket with
 the backtrace.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28865#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list