[tor-bugs] #27609 [Applications/Tor Browser]: TBA: Evaluate Tor Onion Proxy Library

[Tor Bug Tracker & Wiki]

#27609: TBA: Evaluate Tor Onion Proxy Library
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201812,    |  Actual Points:
  TBA-a3                                         |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by sysrqb):

 Replying to [comment:19 sisbell]:
 > Replying to [comment:18 sysrqb]:
 >
 > > Replying to [comment:15 sisbell]:
 > >
 > >
 > >
 > > > Evaluation:
 [snip]
 > > > 1. Stability: Its workable for an alpha, but we should cleanup up
 the threading and socket connections
 > > >
 > > >
 > > >
 > > >
 > >
 > > This is what I'm primarily worried about. Is the code quality where we
 need it. Is it tested? Is the code safe (for some value of safe)? With
 Orbot, we weren't exposing our users to new code (because Orbot was
 previously a dependency). If we use TOPL then we should be confident this
 won't be worse.
 > I tested it back in February of this year and it works. While working on
 the code, I didn't see anything jumping out as unsafe. It's straight-
 forward.

 Great, thanks.

 >
 > >
 > >
 > >
 > >
 > > > In summary: this is not a simply a drop-in. It will need a UI
 defined and built but core functionality is all there. Suggest cleanup of
 threading before a production release.
 > > >
 > > >
 > > >
 > >
 > > Can you estimate how much time this will require? Would we need to re-
 write much of the code and redesign it?
 >
 > Its no more than one week to cleanup threading and the other async
 handling. So not much of the code would need to be re-written. I'm seeing
 TOPL library as more of a replacement for orbotservice.
 >
 [snip]
 >
 > its hard to give exact estimate without going through full list of
 features first. Here is an initial estimate
 >
 >  * Bring TOPL inline with orbotservice - 1 week

 I believe we need a new ticket for this. Please open it when you know what
 work is needed here.

 >  * Pluggable transport build - ??? needs more investigation

 We can combine with this #28802.

 >  * Re-write of Orbot UI and providers - 3 weeks

 The UI is mostly the goal of #28329. Implementing the Hidden Services
 provider will require more work, but we don't need that for the first
 stable version of TBA, so we can ignore it for now.

 >
 > So best case would be about one-man-month. If we wanted to be keep Orbot
 but just integrate TOPL and remove orbotservice, we would be looking at
 more like 2 weeks.

 Hopefully the above provides a better idea of what we're trying to
 accomplish.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27609#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online