[tor-bugs] #28669 [Core Tor/Tor]: Bug: ../src/feature/hs/hs_client.c:280: retry_all_socks_conn_waiting_for_desc

[Tor Bug Tracker & Wiki]

#28669: Bug: ../src/feature/hs/hs_client.c:280:
retry_all_socks_conn_waiting_for_desc
--------------------------+------------------------------------
 Reporter:  traumschule   |          Owner:  (none)
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:
Parent ID:                |         Points:
 Reviewer:  asn           |        Sponsor:
--------------------------+------------------------------------

Comment (by asn):

 Patch LGTM in principle. However, the described scenario in comment:3
 seems pretty implausible, particularly since the original poster gets the
 BUG with two onion services. What's the probability that points 1 and 2
 happened for two onion services before the laptop went into suspend? Maybe
 if the internet went down for some time before the suspend.

 As I said, the patch LGTM, but it would be great if we could reproduce
 this to make sure that the bug occurs and the fix fixes it, since this is
 the second time we are trying to fix this bug. We could repro it in theory
 with shutting down the net, and using faketime or something.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28669#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online