[tor-bugs] #21377 [Core Tor/Tor]: DirAuths should expose bwauth bandwidth files

[Tor Bug Tracker & Wiki]

#21377: DirAuths should expose bwauth bandwidth files
-------------------------------------------------+-------------------------
 Reporter:  tom                                  |          Owner:  juga
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-dirauth, metrics, tor-bwauth,    |  Actual Points:
  035-removed-20180711, 040-roadmap-proposed     |
Parent ID:  #25925                               |         Points:
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 Replying to [comment:43 juga]:
 > Replying to [comment:42 teor]:
 > > It looks like you're setting the compression state, then adding the
 data uncompressed.
 > >
 > > You didn't open a pull request, so I commented on the commit:
 > >
 https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629291
 > >
 https://github.com/torproject/tor/commit/b03091842bc4590e11e3ac026daae8ed6d8f7554#r31629096
 >
 > I didn't create a PR, cause i knew that code fails, but wanted to ask
 about it.

 Please open pull requests for code questions and CI, even if the code
 doesn't work yet.

 When you open a pull request:
 * comments are easier to make and easier to find
 * new commits get handled better
 * the CI is done on a merge with master, so any bugs fixed in master are
 fixed in the CI

 If you don't want a pull request merged, put the ticket in needs_review,
 and say that the code doesn't work.

 Some people also put "WIP" or "work in progress" in the pull request
 title:
 https://stackoverflow.com/a/39741877

 > i've left new comments after setting the compression state.

 I'm not sure how to find the new code, or the CI for that code.

 I tried looking at your branches, but they haven't changed:
 https://github.com/juga0/tor/branches

 When you ask questions, please open a pull request.
 (Or link to a branch, or a commit. But a pull request is better.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21377#comment:44>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online