[tor-bugs] #27597 [Applications/Tor Browser]: ASan build option in tor-browser-build is broken

[Tor Bug Tracker & Wiki]

#27597: ASan build option in tor-browser-build is broken
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-8.0-issues, tbb-regression,      |  Actual Points:
  tbb-rbm, TorBrowserTeam201812R                 |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-8.0-issues, tbb-regression, tbb-rbm => tbb-8.0-issues,
     tbb-regression, tbb-rbm, TorBrowserTeam201812R
 * status:  new => needs_review


Comment:

 Okay, the packaging part at least was so annoying that I wrote a fix for
 that to get more information about WebGL related crashes. `bug_27597`
 (https://gitweb.torproject.org/user/gk/tor-browser.git/log/?h=bug_27597)
 in my `tor-browser has two patches in case we want to get this upstreamed
 to esr60. Here is the issue:

 `dom/bindings/moz.build` contains
 {{{
 TEST_DIRS += ['test']
 }}}

 `python/mozbuild/mozbuild/frontend/context.py` has
 {{{
     'TEST_DIRS': (lambda context: context['DIRS'] if
 context.config.substs.get('ENABLE_TESTS')
                                   else TestDirsPlaceHolder, list,
         """Like DIRS but only for directories that contain test-only code.

         If tests are not enabled, this variable will be ignored.
 }}}
 so, `test` is ignored with --disable-tests, thus
 {{{
 if CONFIG['MOZ_DEBUG']:
     XPIDL_SOURCES += [
         'mozITestInterfaceJS.idl',
     ]

     XPIDL_MODULE = 'dom_bindings_test'
 }}}
 in `dom/bindings/test/moz.build` is not executed which breaks
 {{{
 #if defined(MOZ_DEBUG)
 @RESPATH@/components/dom_bindings_test.xpt
 #endif
 }}}
 if `--enable-debug` is set.

 See: https://bugzilla.mozilla.org/show_bug.cgi?id=1013882 for a similar
 issue.

 Introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=1424362
 (https://hg.mozilla.org/mozilla-central/rev/b1133d2f2c66).

 `layout/moz.build` contains
 {{{
 if CONFIG['MOZ_DEBUG'] and CONFIG['MOZ_WIDGET_TOOLKIT'] != 'android':
     TEST_DIRS += ['tools/layout-debug']
 }}}
 but, as explained above, `TEST_DIRS` is ignored if `--disable-tests` is
 set. Thus
 this breaks
 {{{
 #ifdef MOZ_DEBUG
 @BINPATH@/components/layout_debug.xpt
 #endif
 }}}

 if `--enable-debug` is set.

 Introduced by https://bugzilla.mozilla.org/show_bug.cgi?id=1417664
 (https://hg.mozilla.org/releases/mozilla-esr60/rev/07d02e9d114c).

 Setting `needs_review` for the `--enable-debug` related part.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27597#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online