[tor-bugs] #28851 [Core Tor/Tor]: Do we really need to check our hardwired DH primes at startup?

[Tor Bug Tracker & Wiki]

#28851: Do we really need to check our hardwired DH primes at startup?
---------------------------+-----------------------------------------------
     Reporter:  nickm      |      Owner:  (none)
         Type:  defect     |     Status:  new
     Priority:  Medium     |  Milestone:  Tor: 0.4.0.x-final
    Component:  Core       |    Version:  Tor: 0.3.4.9
  Tor/Tor                  |
     Severity:  Normal     |   Keywords:  startup performance  035-backport
Actual Points:             |  Parent ID:  #28481
       Points:             |   Reviewer:
      Sponsor:             |
  Sponsor8-can             |
---------------------------+-----------------------------------------------
 After the #28837, #28838, and #28839, I note that we're now spending about
 24% of our of our startup time in crypto_validate_dh_params().

 Since our diffie hellman parameters are hardcoded, maybe we don't actually
 need to validate them on every startup, especially on clients?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28851>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online