[tor-bugs] #12885 [Applications/Tor Browser]: Windows Jump Lists fail for Tor Browser

[Tor Bug Tracker & Wiki]

#12885: Windows Jump Lists fail for Tor Browser
-------------------------------------------------+-------------------------
 Reporter:  mcs                                  |          Owner:
                                                 |  pospeselr
     Type:  defect                               |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-usability,                       |  Actual Points:
  TorBrowserTeam201812R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:8 pospeselr]:
 > Replying to [comment:7 mcs]:
 > > Your patch looks OK, but how does the `browser.taskbar.lists.enabled`
 pref relate to the ones you are setting to `false`? It looks like it might
 be a "master switch" that could be used to turn everything off, but I
 would need to look more closely at the code to be sure.
 >
 > Based on some experimentation, the `browser.taskbar.lists.enabled` pref
 does not appear to act as a master switch in this way. After reading the
 code it looks like it may clear the 'recents' list when toggled from true
 to false, but that's about it.

 So, in fact, this does look like a (potential) `master` switch, the
 problem is that old entries are not deleted. It seems a bit weird to me
 that we need to have the whole thing enabled (with the timer to update the
 jumplist still firing all the time) to be sure old entries are deleted
 *and* no new ones are created.

 What about patching the code instead to make sure once during start-up, in
 case `browser.taskbar.lists.enabled` is set to `false`, we remove old
 items, too. The entry point seems to be

 https://dxr.mozilla.org/mozilla-
 esr60/source/browser/components/nsBrowserGlue.js#1173 calling
 `temp.WinTaskbarJumpList.startup();`. That in turn makes us read our prefs
 (`this._refreshPrefs();`) and start the timer for the jump list update
 (`this._updateTimer();`). Maybe we should just call the timer update in
 case the jumplist feature is enabled and if not we delete recent entries
 and that's it? (there would then be no need to disable the three prefs,
 rather we would have turned `browser.taskbar.lists.enabled` into the
 global switch which its name suggests.

 Does that sound reasonable? Or did I miss something while looking at the
 code?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/12885#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online