[tor-bugs] #28743 [Core Tor/Tor]: Tinytest library leaks out into non-test codebase

[Tor Bug Tracker & Wiki]

#28743: Tinytest library leaks out into non-test codebase
--------------------------+------------------------
 Reporter:  karalabe      |          Owner:  (none)
     Type:  defect        |         Status:  new
 Priority:  Medium        |      Milestone:
Component:  Core Tor/Tor  |        Version:
 Severity:  Trivial       |     Resolution:
 Keywords:                |  Actual Points:
Parent ID:                |         Points:
 Reviewer:                |        Sponsor:
--------------------------+------------------------
Changes (by teor):

 * cc: nickm (added)
 * type:  enhancement => defect


Comment:

 Thanks for using Tor, and for reporting this issue.

 Tor depends on tinytest's mocking macros.
 The macros don't do anything in non-test code, but they're still a
 compile-time dependency.
 But it's weird that tinytest refers to src/test. We don't want circular
 dependencies like that.
 nickm wrote tinytest, I'll see if he has any more insight.

 Tor's in-process API is quite new, and we're still testing it.
 If you find any other bugs, please let us know.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28743#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online