[tor-bugs] #28692 [Core Tor/sbws]: sbws should set ConnectionPadding 0

[Tor Bug Tracker & Wiki]

#28692: sbws should set ConnectionPadding 0
---------------------------+-----------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  needs_revision
 Priority:  Medium         |      Milestone:  sbws: 1.0.x-final
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:                 |         Points:
 Reviewer:  teor           |        Sponsor:
---------------------------+-----------------------------------

Comment (by juga):

 Replying to [comment:4 teor]:
 [...]
 > Here's a simpler design:
 > * a list of torrc options in stem.py,

 Even if only stem.py uses these options, i think they should be in
 globals.py, since we might need to change them and globals.py should be
 the place where to change sbws defaults.

 > containing 1., 2. and 4., with a flag saying when the option should be
 applied to tor (1. and 2. on launch, 4. after launch)
 > * a custom list of torrc options that the user can configure for launch
 (same as 3.)
 >
 > (There's an even simpler design in #28712 that makes 3. into a torrc
 file, but it's a breaking change.)

 There isn't a stem torrc syntax parser. This code
 (https://github.com/torproject/sbws/blob/master/sbws/util/stem.py#L157)
 was implementing part of it, it's not complete but was working with well-
 formatted torrc lines.
 I found that the parser for stem configuration
 (https://stem.torproject.org/api/util/conf.html) is very close to what a
 torrc parser would need, yet might not support all the cases
 (https://github.com/torproject/tor/blob/master/doc/torrc_format.txt).

 Options:
 1. we use stem.util.conf, let tor launch fail when options can't be parsed
 and inform the operator
 2. we extend stem.util.conf to become a torrc parser
 3. we implement a full torrc parser
 4. we accept torrc options only in the form of an INI file, which would be
 parsed by ConfigParser and converted to the stem's torrc dictionary (i'm
 not sure which cases might fail here either)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28692#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online