[tor-bugs] #1070 [Mixminion-Server]: Missing space between command and opts

[Tor Bug Tracker & Wiki]

#1070: Missing space between command and opts
------------------------------+-------------------------
 Reporter:  zax               |          Owner:  (none)
     Type:  defect            |         Status:  closed
 Priority:  Low               |      Milestone:
Component:  Mixminion-Server  |        Version:  CVS
 Severity:  Normal            |     Resolution:  wontfix
 Keywords:                    |  Actual Points:
Parent ID:                    |         Points:
 Reviewer:                    |        Sponsor:
------------------------------+-------------------------
Changes (by arma):

 * status:  new => closed
 * resolution:  None => wontfix


Old description:

> There is a space missing between the command and options in Modules.py
> sendSMTPMessage.
>
> --- Modules.py.old      2009-08-26 09:58:39.000000000 +0100
> +++ Modules.py  2009-08-26 09:58:56.000000000 +0100
> @@ -1463,7 +1463,7 @@
>      # FFFF messages in a row.
>      if cfgSection['SendmailCommand'] is not None:
>          cmd, opts = cfgSection['SendmailCommand']
> -        command = cmd + (" ".join(opts))
> +        command = cmd + " " + (" ".join(opts))
>          f = os.popen(command, 'w')
>          f.write(message)
>          f.close()
>
> [Automatically added by flyspray2trac: Operating System: All]

New description:

 There is a space missing between the command and options in Modules.py
 sendSMTPMessage.

 --- Modules.py.old      2009-08-26 09:58:39.000000000 +0100
 +++ Modules.py  2009-08-26 09:58:56.000000000 +0100
 @@ -1463,7 +1463,7 @@
      # FFFF messages in a row.
      if cfgSection['SendmailCommand'] is not None:
          cmd, opts = cfgSection['SendmailCommand']
 -        command = cmd + (" ".join(opts))
 +        command = cmd + " " + (" ".join(opts))
          f = os.popen(command, 'w')
          f.write(message)
          f.close()

 [Automatically added by flyspray2trac: Operating System: All]

--

Comment:

 mixminion is dead; long live mixminion

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1070#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online