[tor-bugs] #28668 [Core Tor/Tor]: If a Tor unit test causes a BUG log, it should fail

[Tor Bug Tracker & Wiki]

#28668: If a Tor unit test causes a BUG log, it should fail
----------------------------+------------------------------------
 Reporter:  teor            |          Owner:  (none)
     Type:  enhancement     |         Status:  new
 Priority:  Medium          |      Milestone:  Tor: 0.4.0.x-final
Component:  Core Tor/Tor    |        Version:
 Severity:  Normal          |     Resolution:
 Keywords:  technical-debt  |  Actual Points:
Parent ID:                  |         Points:
 Reviewer:                  |        Sponsor:
----------------------------+------------------------------------

Comment (by dgoulet):

 Replying to [comment:2 teor]:
 > In that ticket, we fixed all the bug warnings, but *didn't* make tests
 fail on BUG().
 >
 > This time, we should fix all the bug warnings, and make the tests fail
 on BUG().

 +1.

 (Just to be clear, `BUG()` _and_ `log_warn(LD_BUG, ...)` should fail
 unless we expect them). #28660 had a `LD_BUG` since 0.2.8 that we never
 noticed :S...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28668#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online