[tor-bugs] #23588 [Core Tor/Tor]: Write fascist_firewall_choose_address_ls() and use it in hs_get_extend_info_from_lspecs()

[Tor Bug Tracker & Wiki]

#23588: Write fascist_firewall_choose_address_ls() and use it in
hs_get_extend_info_from_lspecs()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328                           |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision


Comment:

 We just need a few tweaks to the log messages: if the remote side sends
 bad data, it's a protocol warning, not a bug warning. (This was my mistake
 in my last review.)

 Maybe we should also log warnings when we don't have a legacy ID or a
 reachable IP address?
 * a missing legacy ID is a protocol warning
 * an unreachable IP address is an info-level warning (not a bug and not a
 protocol warning, because it can happen without any side doing the wrong
 thing)
 https://github.com/torproject/tor/pull/256/commits/d838a4beab1737faff1840666ec8dce1200881d8
 #diff-b2566dcf1fb829adf3289823089d4ad4R1752

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23588#comment:68>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online