[tor-bugs] #28027 [Core Tor/Tor]: Tor keeps opening circuits while waiting for bridge descriptors

[Tor Bug Tracker & Wiki]

#28027: Tor keeps opening circuits while waiting for bridge descriptors
-------------------------------------------------+-------------------------
 Reporter:  dgoulet                              |          Owner:  neel
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.0.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.0.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-hs, regression, tor-guard,       |  Actual Points:
  033-backport, 034-backport, 035-backport       |
Parent ID:                                       |         Points:
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_revision
 * reviewer:   => teor


Comment:

 Do we need the extra call to note_that_we_completed_a_circuit()?

 The existing call happens when tor completes a multi-hop circuit:
 https://github.com/torproject/tor/blob/586c3a7c902dfb6fdf52390ecb2a08d6fceef77a/src/core/or/circuitbuild.c#L1055

 So calling note_that_we_completed_a_circuit() when we make a one-hop
 circuit to a bridge might not be a good idea.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28027#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online