[tor-bugs] #27246 [Core Tor/Tor]: Can we use less space for RSA onion keys on clients?

[Tor Bug Tracker & Wiki]

#27246: Can we use less space for RSA onion keys on clients?
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #27243                               |         Points:
 Reviewer:  nickm                                |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by dgoulet):

 * status:  needs_revision => needs_review


Comment:

 Replying to [comment:5 nickm]:
 > Nice! I expect that the memory savings will be even better than expected
 in the commit message, since the "408 vs 140" calculation doesn't include
 malloc overhead.
 >
 > I suggested a few small changes on the ticket, and found (what I think
 is) one real bug.
 >
 > Question: Have you tested this for memory leaks? I didn't see any, but
 that would be the kind of bug I'd want to watch out for here.

 I have not run this under valgrind but no leaks occur in the test. There
 are a LOT of code path in the unit tests that touches the md/ri and I know
 because I had a leak during development and noticed very quickly.

 See fixup commits on the PR.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27246#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online