[tor-bugs] #27308 [Core Tor/Tor]: add completion milestones to bootstrap

[Tor Bug Tracker & Wiki]

#27308: add completion milestones to bootstrap
-------------------------------------------------+-------------------------
 Reporter:  catalyst                             |          Owner:
                                                 |  catalyst
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  usability, ux, ux-team, bootstrap,   |  Actual Points:
  035-roadmap-subtask, 035-triaged-in-20180711,  |
  s8-bootstrap                                   |
Parent ID:  #22266                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by catalyst):

 The following bootstrap milestones (maybe not an exhaustive list) get
 reported by the preceding step, not by code that actually starts the next
 milestone:
 * `BOOTSTRAP_STATUS_REQUESTING_STATUS` (20)
 * `BOOTSTRAP_STATUS_HANDSHAKE` (-2)
 * `BOOTSTRAP_STATUS_REQUESTING_DESCRIPTORS` (45)
 * `BOOTSTRAP_STATUS_CONN_OR` (80)

 `BOOTSTRAP_STATUS_REQUESTING_STATUS` is reported by
 `circuit_build_no_more_hops()` when it observes that a single-hop circuit
 has completed.

 `BOOTSTRAP_STATUS_HANDSHAKE` is reported by
 `connection_or_finished_connecting()` when it probably should be reported
 by `connection_tls_start_handshake()`.

 `BOOTSTRAP_STATUS_REQUESTING_DESCRIPTORS` is reported by
 `update_router_have_minimum_dir_info()`, which doesn't actually initiate
 the descriptor downloads.

 `BOOTSTRAP_STATUS_CONN_OR` is reported by
 `update_router_have_minimum_dir_info()` when it probably should actually
 be reported by the connection launch code in `circuit_handle_first_hop()`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27308#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online