[tor-bugs] #27224 [Core Tor/Tor]: Call node_get_all_orports() less from node_is_a_configured_bridge()

[Tor Bug Tracker & Wiki]

#27224: Call node_get_all_orports() less from node_is_a_configured_bridge()
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  rl1987
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #26630                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  merge_ready => needs_revision


Comment:

 I don't think this will actually return the same results as the old
 function.

 In the case when the bridge has no identity set, but where the node does
 have an identity (*), this code will always return "false" -- but the old
 code would check the addresses in that case.

 There may be other cases when the outputs are different; I'm not sure that
 I spotted them all.

 (*) I think the node will always have an identity, in fact.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27224#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online