[tor-bugs] #27337 [Core Tor/sbws]: Round relay bandwidths in bandwidth files

[Tor Bug Tracker & Wiki]

#27337: Round relay bandwidths in bandwidth files
---------------------------+-------------------------------------
 Reporter:  teor           |          Owner:  (none)
     Type:  defect         |         Status:  new
 Priority:  Medium         |      Milestone:  sbws 1.0 (MVP must)
Component:  Core Tor/sbws  |        Version:
 Severity:  Normal         |     Resolution:
 Keywords:                 |  Actual Points:
Parent ID:  #27108         |         Points:
 Reviewer:                 |        Sponsor:
---------------------------+-------------------------------------

Comment (by teor):

 Replying to [comment:4 juga]:
 > Replying to [ticket:27337 teor]:
 > > === Avoiding Zeroes ===
 > >
 > > I think sbws should also increase 0 bandwidths to 1.
 >
 > hmm, which one of the bandwidth values?. So far the we round all decimal
 values and take max(value, 1). The only bandwidth that can still be 0 is
 the descriptor observed bandwidth, that's it's also rounded and take min 1
 after it's multiplied by the ratio. Should the descriptor observed
 bandwidth be at least 1 before multiplying by the ratio?

 Each relay's consensus weight in the vote must be >= 1.

 You know the sbws code better than I do, so you can implement that however
 you want.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27337#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online