[tor-bugs] #23576 [Core Tor/Tor]: Make service_intro_point_new() take a node instead of an extend_info

[Tor Bug Tracker & Wiki]

#23576: Make service_intro_point_new() take a node instead of an extend_info
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  prop224, tor-hs, single-onion,       |  Actual Points:
  ipv6, 034-triage-20180328,                     |
  034-removed-20180328, fast-fix                 |
Parent ID:  #23493                               |         Points:  1
 Reviewer:  asn                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 On macOS 10.13 with tor bug23576-rebased and chutney 0ccad53 (or later) I
 see:
 {{{
 $ make test-network-all
  cd . && /bin/sh ./config.status Makefile depfiles
 config.status: creating Makefile
 config.status: executing depfiles commands
 mkdir -p ./test_network_log
 ping6 ::1 and ping ::1 failed, skipping IPv6 flavors: bridges+ipv6-min
 ipv6-exit-min hs-v23-ipv6-md single-onion-ipv6-md.
 tor-stable not found, skipping mixed flavors: mixed+hs-v23.
 SKIP: bridges+ipv6-min
 SKIP: ipv6-exit-min
 SKIP: hs-v23-ipv6-md
 SKIP: single-onion-ipv6-md
 SKIP: mixed+hs-v23
 PASS: basic-min
 PASS: bridges-min
 PASS: hs-v2-min
 FAIL: hs-v3-min
 FAIL: single-onion-v23
 Log and result files are available in ./test_network_log.
 make: *** [test-network-all] Error 1
 Exit 2
 }}}

 When I merge bug23576-rebased into master to pick up the latest fixes, I
 see similar output. I'll have a look into it later this week.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23576#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online